Install buildifier via Bazel #2777
Conversation
npaun
force-pushed
the
npaun/buildifier-in-bazel
branch
2 times, most recently
from
946be0a
to
9a68e92
Compare
npaun
force-pushed
the
npaun/buildifier-in-bazel
branch
from
9a68e92
to
16d364a
Compare
|
Based on @danlapid's suggestion, I added some code to let |
npaun
force-pushed
the
npaun/buildifier-in-bazel
branch
2 times, most recently
from
f60d34d
to
348c80f
Compare
|
What I meant with my comment re. config_setting_group was to still have them to define an alias for the binary with the right architecture, but to define the groups in a new file in the build folder and use that to fold up the groups that we have so far in rust-deps/BUILD.bazel. That feels cleaner than doing platform selection in python, but I assume that would cause issues with running the binary directly instead of through bazel, so not opposed to this approach. |
npaun
force-pushed
the
npaun/buildifier-in-bazel
branch
from
348c80f
to
95f6484
Compare
|
@fhanau Yep, your suggestion makes sense, but I wanted direct running of the binary to speed things up where possible. |
npaun
force-pushed
the
npaun/buildifier-in-bazel
branch
from
95f6484
to
e72ce73
Compare
| # formatter=prettier, | ||
| # ), | ||
| # FormatConfig(directory="src", globs=("*.json",), formatter=prettier), | ||
| FormatConfig( |
There was a problem hiding this comment.
Restoring prettier because it is already installed by bazel
| # globs=("*.bzl", "WORKSPACE", "BUILD", "BUILD.*"), | ||
| # formatter=buildifier, | ||
| # ), | ||
| FormatConfig( |
There was a problem hiding this comment.
Restoring buildifier because this PR installs it via Bazel
| # formatter=prettier, | ||
| # ), | ||
| # FormatConfig(directory="src", globs=("*.json",), formatter=prettier), | ||
| FormatConfig( |
There was a problem hiding this comment.
was prettier intended to be included? Imo it requires running npm install or something and is not fetched automatically?
There was a problem hiding this comment.
It's listed as a runtime dependency of workerd, so it's somewhere... I'm currently doing a clean build to find out where it puts it.
There was a problem hiding this comment.
Found it (bazel-bin/node_modules/prettier/bin/prettier.cjs)
I thought about this too, and while it can be done I don't see a particular value of doing it that way. You'll have to do |
* Install buildifier via Bazel * Update path to prettier * Update path to prettier
No description provided.